Skip to content

Conversation

@derekhiggins
Copy link
Contributor

@derekhiggins derekhiggins commented Nov 27, 2019

Add support for provisioing over IPv6

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2019
@derekhiggins
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 27, 2019
@hardys
Copy link

hardys commented Nov 29, 2019

/label platform/baremetal

@openshift-ci-robot openshift-ci-robot added the platform/baremetal IPI bare metal hosts platform label Nov 29, 2019
@metal3ci
Copy link

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1340/

@derekhiggins derekhiggins changed the title WIP: Changes needed for IPv6 Changes needed for IPv6 Dec 20, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2019
@derekhiggins
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2019
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, this doesn't work for me, as i don't seem to have any ipv6 default route (even if i enabled router advertisements). However, it worked with an alternative command: /sbin/ip -6 addr show provisioning | grep inet6 | awk -F '[ \t]+|/' '{print $3}' | grep -v ^::1 | grep -v ^fe80

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, will update

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2020
@stbenjam
Copy link
Member

#2895 has been merged so you should be able to rebase now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2916 includes these fixes, it should land soon

@stbenjam
Copy link
Member

@derekhiggins Could you rebase this PR?

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 22, 2020
@derekhiggins derekhiggins force-pushed the ipv6 branch 2 times, most recently from 07daa02 to 09d509d Compare January 23, 2020 11:51
@derekhiggins
Copy link
Contributor Author

/retest

@metal3ci
Copy link

metal3ci commented Feb 3, 2020

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1478/

@metal3ci
Copy link

metal3ci commented Feb 6, 2020

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1484/

@metal3ci
Copy link

metal3ci commented Feb 6, 2020

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1485/

@stbenjam
Copy link
Member

stbenjam commented Feb 6, 2020

Sorry for delay, baremetal IPI deploys have been broken due to a couple of issues.
CI is now facing some time outs but I get a good local install using this PR.

@stbenjam
Copy link
Member

stbenjam commented Feb 6, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
# be the same host, if none is found then the downloader containers just skip and download
# from the internet location ( IP=n.n.n.n:nn or [x:x::x]:nn )
IP=$(echo $RHCOS_BOOT_IMAGE_URL | sed -e 's/.*:\/\/\([^/]*\)\/.*/\1/g' )
CACHEURL="http://$IP/images"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since openshift/ironic-rhcos-downloader#24 this is no longer used, but I guess we can remove that in a follow-up PR

@hardys
Copy link

hardys commented Feb 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@metal3ci
Copy link

metal3ci commented Feb 6, 2020

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1489/

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ccb3cc3 into openshift:master Feb 7, 2020
@openshift-ci-robot
Copy link
Contributor

@derekhiggins: All pull requests linked via external trackers have merged. Bugzilla bug 1797638 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1797638: baremetal: Changes needed for IPv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@derekhiggins: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 8ee6d5b link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-libvirt 8ee6d5b link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member

/cherry-pick release-4.3

@openshift-cherrypick-robot

@stbenjam: new pull request created: #3097

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/baremetal IPI bare metal hosts platform size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants